Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mingw shared library suffix .dll.a support #1674

Closed
xq114 opened this issue Sep 15, 2021 · 5 comments
Closed

mingw shared library suffix .dll.a support #1674

xq114 opened this issue Sep 15, 2021 · 5 comments
Milestone

Comments

@xq114
Copy link
Contributor

xq114 commented Sep 15, 2021

注:如果是问题报障或者特性请求,请选择报告缺陷特性请求模板,否则一律不回复。

描述讨论详情

xmake-io/xmake-repo#640

mingw上动态库的import library默认后缀是libfoo.dll.a,链接时加的flag应为-lfoo,与静态库保持一致。在mingw平台使用时,xmake的package自动查找对于动态库应先自动查找.dll.a作为后缀;xmake.lua中添加add_links时应自动识别用户系统上.dll.a后缀的库

@waruqi
Copy link
Member

waruqi commented Sep 15, 2021

这个和 #1589 这个到时候可以一起搞下。。

@waruqi waruqi added this to the v2.5.8 milestone Sep 15, 2021
@waruqi
Copy link
Member

waruqi commented Sep 15, 2021

可以测试下这个 patch #1675

这个改动也许会影响部分 mingw case ,毕竟测试不全,也许会有遗漏,帮忙多测测吧。

@xq114
Copy link
Contributor Author

xq114 commented Sep 16, 2021

@waruqi
Copy link
Member

waruqi commented Sep 16, 2021

https://github.com/xmake-io/xmake/blob/master/xmake/modules/package/manager/xmake/find_package.lua

这里自动查找也要改

这里不是已经改了么。。看 mingw 分支

@waruqi
Copy link
Member

waruqi commented Sep 17, 2021

已经合进去了,我这边测试 ok,你可以看下,有问题再开

@waruqi waruqi closed this as completed Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants