-
-
Notifications
You must be signed in to change notification settings - Fork 812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vsxmake生成的文件组不正确 #5589
Comments
Title: The file group generated by vsxmake is incorrect Xmake version2.9.4 Operating system version and architecturewindows 10 Describe the problemIf filter is the current directory, that is, ".", then filter should not be generated, but this line
will change filter to nil, and this line will recalculate filter because of nil
Expected resultsDo not change the filter. When the test finds that filter = ".", vs will not generate a file group, and no special processing of "." is required. Project configurationnone Additional information and error logsNone |
Change filter to nil before return. Fix xmake-io#5589.
vs generator 里面也同步改下
|
Also change it simultaneously in vs generator.
|
Xmake 版本
2.9.4
操作系统版本和架构
windows 10
描述问题
如果filter是当前目录,也就是".",那么就不应该生成filter,但是这一行
xmake/xmake/plugins/project/vsxmake/getinfo.lua
Line 357 in 1dfec90
会把filter变成nil,而这一行会因为nil重新计算filter
xmake/xmake/plugins/project/vsxmake/getinfo.lua
Line 370 in 1dfec90
期待的结果
不要更改filter,测试发现filter = "."的时候,vs不会生成文件组,不需要特殊处理"."
工程配置
无
附加信息和错误日志
无
The text was updated successfully, but these errors were encountered: