Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vsxmake生成的文件组不正确 #5589

Closed
Domain opened this issue Sep 9, 2024 · 3 comments · Fixed by #5590
Closed

vsxmake生成的文件组不正确 #5589

Domain opened this issue Sep 9, 2024 · 3 comments · Fixed by #5590
Labels

Comments

@Domain
Copy link
Contributor

Domain commented Sep 9, 2024

Xmake 版本

2.9.4

操作系统版本和架构

windows 10

描述问题

如果filter是当前目录,也就是".",那么就不应该生成filter,但是这一行


会把filter变成nil,而这一行会因为nil重新计算filter
if not filter and not is_plain then

期待的结果

不要更改filter,测试发现filter = "."的时候,vs不会生成文件组,不需要特殊处理"."

工程配置

附加信息和错误日志

@Domain Domain added the bug label Sep 9, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Title: The file group generated by vsxmake is incorrect

Xmake version

2.9.4

Operating system version and architecture

windows 10

Describe the problem

If filter is the current directory, that is, ".", then filter should not be generated, but this line


will change filter to nil, and this line will recalculate filter because of nil
if not filter and not is_plain then

Expected results

Do not change the filter. When the test finds that filter = ".", vs will not generate a file group, and no special processing of "." is required.

Project configuration

none

Additional information and error logs

None

Domain added a commit to Domain/xmake that referenced this issue Sep 9, 2024
Change filter to nil before return. Fix xmake-io#5589.
@Domain Domain mentioned this issue Sep 9, 2024
@waruqi
Copy link
Member

waruqi commented Sep 9, 2024

vs generator 里面也同步改下

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Also change it simultaneously in vs generator.

Domain added a commit to Domain/xmake that referenced this issue Sep 9, 2024
Domain added a commit to Domain/xmake that referenced this issue Sep 9, 2024
waruqi added a commit that referenced this issue Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants