Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve group name uuid #2226

Merged
merged 2 commits into from
Mar 30, 2022
Merged

Improve group name uuid #2226

merged 2 commits into from
Mar 30, 2022

Conversation

shuax
Copy link
Contributor

@shuax shuax commented Mar 30, 2022 

target("lib")
    set_kind("static")
    add_files("src/lib.c")
    set_group("lib")

If the group name is the same as the target, then they will generate the same uuid, causing a conflict.

@shuax
Copy link
Contributor Author

shuax commented Mar 30, 2022

额，选错了分支了。

@waruqi waruqi changed the base branch from master to dev March 30, 2022 13:38
@waruqi
Copy link
Member

waruqi commented Mar 30, 2022 •
edited
Loading

为什么两个文件改动这么大？编码改了？还是换行变了？尽量只保证最小 diff

@shuax
Copy link
Contributor Author

shuax commented Mar 30, 2022

为什么两个文件改动这么大？编码改了？尽量只保证最小 diff

可能是回车变了，我再弄弄

@shuax
Copy link
Contributor Author

shuax commented Mar 30, 2022

换行符改回来了

@waruqi waruqi merged commit 06b374d into xmake-io:dev Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shuax @waruqi