Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Werror and dry-run flags for clang-format #5908

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Add Werror and dry-run flags for clang-format #5908

merged 2 commits into from
Dec 1, 2024

Conversation

jj683
Copy link
Contributor

@jj683 jj683 commented Nov 30, 2024 •
edited
Loading

Support additional optional flags for clang-format:

--Werror                       - If set, changes formatting warnings to errors
--dry-run                      - If set, do not actually make the formatting changes
-n                             - Alias for --dry-run
--verbose                      - If set, shows the list of processed files

waruqi
waruqi reviewed Nov 30, 2024
View reviewed changes
xmake/plugins/format/xmake.lua Outdated
{nil, "create", "k", nil, "Create a .clang-format file from a coding style"},
{'n', "dry-run", "k", nil, "Do not make any changes, just show the files that would be formatted."},
{'e', "error", "k", nil, "If set, changes formatting warnings to errors."},
{'v', "verbose", "k", nil, "Print verbose information."},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verbose is builtin option

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well noted, fixed.

@waruqi waruqi merged commit 50f38ee into xmake-io:dev Dec 1, 2024
19 checks passed
@waruqi waruqi added this to the v2.9.7 milestone Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waruqi waruqi waruqi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.9.7
Development

Successfully merging this pull request may close these issues.
2 participants
@jj683 @waruqi