deb pack qt

[RubMaker]

• Before adding new features and new modules, please go to issues to submit the relevant feature description first.
• Write good commit messages and use the same coding conventions as the rest of the project.
• Please commit code to dev branch and we will merge into master branch in feature
• Ensure your edited codes with four spaces instead of TAB.

---

• 增加新特性和新模块之前，请先到issues提交相关特性说明，经过讨论评估确认后，再进行相应的代码提交，避免做无用工作。
• 编写友好可读的提交信息，并使用与工程代码相同的代码规范，代码请用4个空格字符代替tab缩进。
• 请提交代码到dev分支，如果通过，我们会在特定时间合并到master分支上。
• 为了规范化提交日志的格式，commit消息，不要用中文，请用英文描述。

[gemini-code-assist]

Summary of Changes

Hello @RubMaker, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Xmake Debian packaging plugin by introducing robust support for Qt projects. It implements intelligent detection of Qt applications, automatically determines and includes the correct Qt5 or Qt6 runtime and build dependencies, and integrates a mechanism to remove RPATH from binaries. These changes streamline the packaging of Qt-based software for Debian, improving compatibility and maintainability, while also standardizing maintainer metadata.

Highlights

• Qt Project Detection and Dependency Management: The plugin now automatically detects if a project is Qt-based by analyzing linked libraries, executable dependencies (via ldd), and source file includes. Based on the detected Qt version (Qt5 or Qt6) and specific modules used, it dynamically generates appropriate Debian runtime and build dependencies.
• Automatic RPATH Removal: To ensure better system integration and adherence to Debian packaging best practices, the plugin now automatically identifies and removes RPATH (Run-time search path) from all installed executables and shared libraries using the chrpath tool during the Debian package build process.
• Maintainer Information Validation: A new validation function has been introduced to ensure that the package maintainer information is correctly formatted (e.g., 'Name email@example.com'), providing a fallback to a default format if needed.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds functionality for packaging Qt applications into Debian (.deb) packages. The changes include detecting Qt projects, determining Qt dependencies, and handling RPATH for binaries.

My review focuses on improving code quality and performance. I've identified a few areas for improvement:

• Removal of a debug print statement.
• Refactoring duplicated code for determining Qt dependencies to improve maintainability.
• Removing a redundant and inefficient implementation for RPATH removal, favoring a more standard approach already present in the debian/rules file.

Overall, this is a great addition. Addressing these points will make the implementation more robust and maintainable.

[gemini-code-assist]

The logic to remove RPATH is duplicated. It's implemented here in Lua (by calling _remove_rpath_from_binaries) and also directly in xmake/scripts/xpack/deb/debian/rules using find commands. The find commands in the rules file are more efficient and idiomatic for Debian packaging. This Lua implementation is redundant and less performant, as it iterates through all files and calls file and chrpath for each one.

To avoid redundancy and improve performance, this block should be removed. The _remove_rpath_from_binaries function (lines 209-236) and _get_chrpath function (lines 39-42) also become unnecessary and can be removed.

[gemini-code-assist]

This print statement appears to be for debugging. It should be removed from production code to avoid unnecessary console output.

[gemini-code-assist]

This function has a lot of duplicated logic for handling Qt5 and Qt6 dependencies.

• The package:get("links") call is duplicated. It can be moved to the top of the function.
• The large if/elseif blocks for detecting modules are almost identical for Qt5 and Qt6. This makes the code hard to read and maintain.

This can be refactored using a data-driven approach. For example, you could define maps for Qt5 and Qt6 modules and their corresponding packages:

local qt6_module_map = {
    network   = { dep = "libqt6network6" },
    sql       = { dep = "libqt6sql6" },
    opengl    = { dep = "libqt6opengl6", build_dep = "qt6-opengl-dev" },
    -- etc.
}

-- in the loop over links
for mod_name, deps in pairs(qt6_module_map) do
    if lower_link:find("qt6" .. mod_name) or lower_link:find("qt" .. mod_name) then
        table.insert(qt_deps, deps.dep)
        if deps.build_dep then
            table.insert(qt_build_deps, deps.build_dep)
        end
    end
end

A similar map can be created for Qt5. This would make the code much cleaner and easier to extend.

[waruqi]

同样，都放到 qt rules 里面去做。

#6826 (comment)

[Issues-translate-bot]

Bot detected the issue body's language is not English, translate it automatically.

---

Similarly, put them in qt rules to do it.

#6826 (comment)