Implements support for UITableViewCellStyleSubtitle on FieldRow #1468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys! First of all I would like to thank you all for the work you do! :D
Case:
Almost all row types in Eureka use a stock UIKit UITableViewCell as underlying cell. So if you change the UITableViewCellStyle of that cell if automatically changes the UI of the Eureka row.
But that are some rows that are backed by a custom Eureka row (FieldRow). So setting the UITableViewCellStyle of that cell doesn't affect the UI.
Solution:
I've changed the customConstraints method on FieldRow to change its layout if the row have a .subtitle style.
I develop in a way it doesn't modify the previous behaviour (keeping the same code). And just add an case for this new style.
The new layout code is very similar to the old one, so I guess its self explanatory.
We are using in production for some time. And we think this should be the available to everyone.
Any improvements or comments are welcome. Maybe we can improve it even more!
Thanks