Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark tableView editActionsForRowAt as deprecated #2000

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Mark tableView editActionsForRowAt as deprecated #2000

merged 1 commit into from
Mar 10, 2020

Conversation

davidrothera
Copy link
Contributor

@davidrothera davidrothera commented Mar 8, 2020

The corresponding method is deprecated as of iOS 13 and emits a warning when building on iOS13 and greater projects.

This marks the method as deprecated and directs users to use the leading/trailing based API instead (which has already been implemented here).

Comment showing deprecation from UIKit/UITableView.h

// This method supersedes -tableView:titleForDeleteConfirmationButtonForRowAtIndexPath: if return value is non-nil
- (nullable NSArray<UITableViewRowAction *> *)tableView:(UITableView *)tableView editActionsForRowAtIndexPath:(NSIndexPath *)indexPath API_DEPRECATED_WITH_REPLACEMENT("tableView:trailingSwipeActionsConfigurationForRowAtIndexPath:", ios(8.0, 13.0)) API_UNAVAILABLE(tvos);

The corresponding method is deprecated as of iOS 13 and emits a warning when building on iOS13 and greater projects.

This marks the method as deprecated and directs users to use the leading/trailing based API instead (which has already been implemented here).
@davidrothera
Copy link
Contributor Author

@mats-claassen could you perhaps take a look here? The warning stemming from the Eureka-Swift.h is setting off my OCD 😝

@mats-claassen mats-claassen merged commit e2b1720 into xmartlabs:master Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants