Add swiftlint & fixes #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagofm
force-pushed
the
feature/swiftlint
branch
2 times, most recently
from
5f6235c
to
8890f7f
Compare
santiagofm
force-pushed
the
feature/swiftlint
branch
2 times, most recently
from
74ee851
to
1d8f081
Compare
m-revetria
approved these changes
May 23, 2017
| navigationItem.titleView = bigLabel | ||
| bigLabel.sizeToFit() | ||
| } | ||
|
|
||
| if let pagerViewController = childViewControllers.filter( { $0 is PagerTabStripViewController } ).first as? PagerTabStripViewController { | ||
| let pagerViewController = childViewControllers.filter { $0 is PagerTabStripViewController }.first as? PagerTabStripViewController |
There was a problem hiding this comment.
please consider changing .filter { ... }.first to just .first { ... }
.swiftlint.yml
Outdated
| @@ -0,0 +1,51 @@ | |||
| disabled_rules: # rule identifiers to exclude from running | |||
| - colon | |||
There was a problem hiding this comment.
These are a lot of disables rules, would be nice if you enable them and fix or disabling locally depending on each case.
santiagofm
force-pushed
the
feature/swiftlint
branch
2 times, most recently
from
ba383fb
to
46869c0
Compare
santiagofm
force-pushed
the
feature/swiftlint
branch
from
46869c0
to
0b7dc7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added swiftlint to the project & fixed every error/warning