Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ProvideMetricValidator to be more helpful #100

Merged
merged 3 commits into from
May 11, 2021
Merged

Conversation

kristinapathak
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #100 (bc3277d) into main (4df8762) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   68.81%   68.81%           
=======================================
  Files          38       38           
  Lines         978      978           
=======================================
  Hits          673      673           
  Misses        286      286           
  Partials       19       19           
Impacted Files Coverage Δ
basculechecks/provide.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4df8762...bc3277d. Read the comment docs.

@kristinapathak kristinapathak requested a review from joe94 May 11, 2021 00:26
@kristinapathak kristinapathak added the bug Something isn't working label May 11, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone May 11, 2021
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kristinapathak kristinapathak merged commit 851b72c into main May 11, 2021
@kristinapathak kristinapathak deleted the fix-provide branch May 11, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants