Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change error response reason to be snake case stringified #102

Merged
merged 3 commits into from
May 12, 2021

Conversation

kristinapathak
Copy link
Contributor

No description provided.

@kristinapathak kristinapathak added the enhancement New feature or request label May 11, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone May 11, 2021
@kristinapathak kristinapathak requested review from kcajmagic and joe94 May 11, 2021 23:42
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #102 (41680c7) into main (b3a0236) will increase coverage by 0.33%.
The diff coverage is 100.00%.

❗ Current head 41680c7 differs from pull request most recent head 92bf25e. Consider uploading reports for the commit 92bf25e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #102      +/-   ##
==========================================
+ Coverage   68.60%   68.94%   +0.33%     
==========================================
  Files          38       37       -1     
  Lines         981      982       +1     
==========================================
+ Hits          673      677       +4     
+ Misses        289      286       -3     
  Partials       19       19              
Impacted Files Coverage Δ
basculehttp/errorResponseReason.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3a0236...92bf25e. Read the comment docs.

@kristinapathak kristinapathak merged commit 5a74a01 into main May 12, 2021
@kristinapathak kristinapathak deleted the fix-label branch May 12, 2021 20:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants