-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
uber fx Provide() funcs #104
Conversation
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
- Coverage 68.94% 59.08% -9.86%
==========================================
Files 37 43 +6
Lines 982 1183 +201
==========================================
+ Hits 677 699 +22
- Misses 286 462 +176
- Partials 19 22 +3
Continue to review full report at Codecov.
|
and leeway options for the MetricListener
This pull request introduces 1 alert when merging aff0a8c into 5a74a01 - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🚀 Just minor comments
SonarCloud Quality Gate failed. |
Adding helper functions to make it easier to wire everything together, with or without uber fx.