Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uber fx Provide() funcs #104

Merged
merged 25 commits into from
May 19, 2021
Merged

uber fx Provide() funcs #104

merged 25 commits into from
May 19, 2021

Conversation

kristinapathak
Copy link
Contributor

Adding helper functions to make it easier to wire everything together, with or without uber fx.

@kristinapathak kristinapathak added the enhancement New feature or request label May 13, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone May 13, 2021
@codecov
Copy link

codecov bot commented May 13, 2021

Codecov Report

Merging #104 (b7dd373) into main (5a74a01) will decrease coverage by 9.85%.
The diff coverage is 22.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   68.94%   59.08%   -9.86%     
==========================================
  Files          37       43       +6     
  Lines         982     1183     +201     
==========================================
+ Hits          677      699      +22     
- Misses        286      462     +176     
- Partials       19       22       +3     
Impacted Files Coverage Δ
basculechecks/errors.go 100.00% <ø> (ø)
basculechecks/metrics.go 0.00% <ø> (ø)
basculechecks/metricvalidator.go 100.00% <ø> (ø)
basculechecks/provide.go 0.00% <0.00%> (ø)
basculehttp/basicTokenFactory.go 67.50% <0.00%> (ø)
basculehttp/bearerTokenFactory.go 0.00% <0.00%> (ø)
basculehttp/chain.go 0.00% <0.00%> (ø)
basculehttp/errorResponseReason.go 100.00% <ø> (ø)
basculehttp/http.go 100.00% <ø> (ø)
basculehttp/listener.go 100.00% <ø> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a74a01...b7dd373. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 18, 2021

This pull request introduces 1 alert when merging aff0a8c into 5a74a01 - view on LGTM.com

new alerts:

  • 1 for Clear-text logging of sensitive information

@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@xmidt-org xmidt-org deleted a comment from lgtm-com bot May 18, 2021
@kristinapathak kristinapathak requested a review from joe94 May 18, 2021 03:55
@kristinapathak kristinapathak marked this pull request as ready for review May 18, 2021 03:55
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀 Just minor comments

basculehttp/bearerTokenFactory.go Show resolved Hide resolved
basculehttp/metricListener.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2021

@kristinapathak kristinapathak merged commit c011b12 into main May 19, 2021
@kristinapathak kristinapathak deleted the provide branch May 19, 2021 19:07
@kristinapathak kristinapathak mentioned this pull request May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants