Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token parser #110

Merged
merged 3 commits into from
Jun 15, 2021
Merged

Token parser #110

merged 3 commits into from
Jun 15, 2021

Conversation

kristinapathak
Copy link
Contributor

Moving logic from ancla into the acquirer:
https://github.com/xmidt-org/ancla/blob/0e77127fee33c2a6239dec1d06c77de98b46ca7c/jwtAcquireParser.go

Also added a default keys update interval value.

@kristinapathak kristinapathak added the enhancement New feature or request label Jun 15, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone Jun 15, 2021
@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #110 (7c705ec) into main (72ba2cf) will decrease coverage by 0.42%.
The diff coverage is 60.00%.

❗ Current head 7c705ec differs from pull request most recent head 2313ba8. Consider uploading reports for the commit 2313ba8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
- Coverage   81.81%   81.39%   -0.43%     
==========================================
  Files          43       44       +1     
  Lines        1144     1161      +17     
==========================================
+ Hits          936      945       +9     
- Misses        185      189       +4     
- Partials       23       27       +4     
Impacted Files Coverage Δ
acquire/bearer.go 90.24% <ø> (+2.48%) ⬆️
key/resolverFactory.go 73.46% <0.00%> (-3.13%) ⬇️
acquire/parsers.go 65.21% <65.21%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72ba2cf...2313ba8. Read the comment docs.

@guardrails
Copy link

guardrails bot commented Jun 15, 2021

⚠️ We detected 1 security issue in this pull request:

Insecure Authentication (1)
Docs Details
💡 Title: JWT decode without verification, Severity: Medium
token, _, err := p.ParseUnverified(string(data), jwt.MapClaims{})

More info on how to fix Insecure Authentication in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@kristinapathak kristinapathak merged commit 19ae566 into main Jun 15, 2021
@kristinapathak kristinapathak deleted the token-parser branch June 15, 2021 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants