Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setLogger Authorization header filtering logic #111

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jun 18, 2021

No description provided.

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #111 (0e3b75c) into main (19ae566) will increase coverage by 0.32%.
The diff coverage is 87.50%.

❗ Current head 0e3b75c differs from pull request most recent head e516a11. Consider uploading reports for the commit e516a11 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   81.39%   81.71%   +0.32%     
==========================================
  Files          44       44              
  Lines        1161     1165       +4     
==========================================
+ Hits          945      952       +7     
+ Misses        189      186       -3     
  Partials       27       27              
Impacted Files Coverage Δ
basculehttp/log.go 72.72% <87.50%> (+14.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19ae566...e516a11. Read the comment docs.

@joe94 joe94 requested a review from kristinapathak June 18, 2021 19:52
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@joe94 joe94 merged commit 33e69a8 into main Jun 29, 2021
@joe94 joe94 deleted the feature/authHeaderLog branch June 29, 2021 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants