Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switched to github.com/golang-jwt/jwt #112

Merged
merged 2 commits into from
Jul 16, 2021
Merged

switched to github.com/golang-jwt/jwt #112

merged 2 commits into from
Jul 16, 2021

Conversation

johnabass
Copy link
Contributor

Addresses security vulnerability [#70]

@johnabass johnabass requested review from joe94 and kristinapathak July 9, 2021 17:32
@codecov
Copy link

codecov bot commented Jul 9, 2021 •
edited
Loading

Codecov Report

Merging #112 (061d825) into main (33e69a8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #112   +/-   ##
=======================================
  Coverage   81.71%   81.71%           
=======================================
  Files          44       44           
  Lines        1165     1165           
=======================================
  Hits          952      952           
  Misses        186      186           
  Partials       27       27
Impacted Files Coverage Δ
acquire/parsers.go 65.21% <ø> (ø)
basculehttp/bearerTokenFactory.go 93.75% <ø> (ø)
jws.go 19.04% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33e69a8...061d825. Read the comment docs.

@johnabass johnabass mentioned this pull request Jul 9, 2021
Closed
@sonarcloud
Copy link

sonarcloud bot commented Jul 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

joe94
joe94 approved these changes Jul 12, 2021
View reviewed changes
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@johnabass johnabass merged commit c947073 into main Jul 16, 2021
@joe94 joe94 deleted the feature/golang-jwt branch July 21, 2021 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

@joe94 joe94 joe94 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnabass @joe94 @kristinapathak