Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated sallust code #167

Merged
merged 6 commits into from
Jan 11, 2023
Merged

Conversation

denopink
Copy link
Contributor

No description provided.

@denopink denopink added the enhancement New feature or request label Jan 11, 2023
@denopink denopink requested review from johnabass and renaz6 January 11, 2023 16:04
@denopink denopink self-assigned this Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #167 (060871d) into main (99fa145) will decrease coverage by 0.49%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #167      +/-   ##
==========================================
- Coverage   89.42%   88.93%   -0.50%     
==========================================
  Files          35       35              
  Lines        1220     1220              
==========================================
- Hits         1091     1085       -6     
- Misses        113      117       +4     
- Partials       16       18       +2     
Flag Coverage Δ
unittests 88.93% <100.00%> (-0.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
basculehttp/constructor.go 97.22% <100.00%> (-2.78%) ⬇️
basculehttp/enforcer.go 88.60% <100.00%> (-3.80%) ⬇️
basculehttp/log.go 39.47% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@denopink denopink merged commit 5fa0212 into main Jan 11, 2023
@denopink denopink deleted the denopink/patch/remove-old-sallust-code branch January 11, 2023 16:39
@sonarcloud
Copy link

sonarcloud bot commented Jan 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@denopink denopink mentioned this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant