Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Normalize both url path and capability substring for endpoint authorization #171

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

denopink
Copy link
Contributor

@denopink denopink added bug Something isn't working enhancement New feature or request labels Jan 19, 2023
@denopink denopink requested review from johnabass and renaz6 January 19, 2023 18:12
@denopink denopink self-assigned this Jan 19, 2023
@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #171 (29b6464) into main (7d6c5d7) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   88.93%   88.97%   +0.04%     
==========================================
  Files          35       35              
  Lines        1220     1225       +5     
==========================================
+ Hits         1085     1090       +5     
  Misses        117      117              
  Partials       18       18              
Flag Coverage Δ
unittests 88.97% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
basculechecks/endpointchecks.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jan 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@denopink denopink merged commit 115d955 into main Jan 20, 2023
@denopink denopink deleted the denopink/bug/normalize-urls-for-endpoint-auth branch January 20, 2023 15:46
@denopink denopink mentioned this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants