Added a customizable function for parsing the request URL #47
Conversation
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
==========================================
- Coverage 77.72% 76.88% -0.85%
==========================================
Files 25 25
Lines 696 731 +35
==========================================
+ Hits 541 562 +21
- Misses 137 151 +14
Partials 18 18
Continue to review full report at Codecov.
|
|
will help with fixing this issue: xmidt-org/webpa-common#62 |
basculehttp/constructor.go
Outdated
| return u.EscapedPath(), nil | ||
| } | ||
|
|
||
| func CreateRemovePrefixURLFunc(prefix string) func(*url.URL) (string, error) { |
There was a problem hiding this comment.
Could the signature of the returned closure not be func(*url.URL) (*url.URL, error)? In other words, return the original URL modified appropriately rather than the string representation. This approach has two (2) benefits:
(1) You or your client can compose things easily, without having to reparse the string repeatedly. For example:
type GetURL func(*url.URL) (*url.URL, error)
func removePrefix(prefix) GetURL { /* remove the prefix */ }
func anotherThing(next GetURL) GetURL {
return func(u *url.URL) (*url.URL, error) {
/* do some other stuff */
return next(u)
}
}
(2) A *url.URL can be useful to a client who wants to do further processing outside bascule. This is related to (1), but has more to do with a client using the results of a GetURL strategy rather than your code.
Since *url.URL is mutable, it's generally good practice to make a copy of the HTTP request's URL member prior to invoking GetURL. You can do this very simply with u := *request.URL, in which case u is of type url.URL and you'll pass &u around.
This will help us get rid of prefixes on request urls (like
/api/v1) before adding them to the context for easier parsing against capabilities for XMiDT/Codex services.