-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bascule Attributes should supported key path getters #52
Conversation
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
==========================================
- Coverage 76.33% 76.07% -0.27%
==========================================
Files 25 25
Lines 731 815 +84
==========================================
+ Hits 558 620 +62
- Misses 155 167 +12
- Partials 18 28 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this - I can't wait to use it! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
fixes #51 |
This PR introduces breaking changes to the library to add support for getting values from a token attribute given a key path.
Todo:
Note: the reason why we need to do an additional casting error check is that viper does not provide it 😢 https://github.com/spf13/cast#usage