Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Helper Function for creating new Basic Token Factory #59

Merged
merged 2 commits into from
May 26, 2020
Merged

Added Helper Function for creating new Basic Token Factory #59

merged 2 commits into from
May 26, 2020

Conversation

kristinapathak
Copy link
Contributor

@kristinapathak kristinapathak commented May 21, 2020 •
edited
Loading

makes it easier to create a Basic Token Factory.

fixes #57

@kristinapathak kristinapathak added the enhancement New feature or request label May 21, 2020
@kristinapathak kristinapathak added this to the Unreleased milestone May 21, 2020
@kristinapathak kristinapathak requested review from joe94 and johnabass May 21, 2020 23:54
@kristinapathak kristinapathak self-assigned this May 21, 2020
@codecov
Copy link

codecov bot commented May 21, 2020 •
edited
Loading

Codecov Report

Merging #59 into master will increase coverage by 0.51%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #59      +/-   ##
==========================================
+ Coverage   78.41%   78.92%   +0.51%     
==========================================
  Files          25       25              
  Lines         820      840      +20     
==========================================
+ Hits          643      663      +20     
  Misses        158      158              
  Partials       19       19
Impacted Files Coverage Δ
basculehttp/tokenFactory.go 51.51% <100.00%> (+21.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1016ff7...f41fea3. Read the comment docs.

joe94
joe94 approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thanks! 🎆

@kristinapathak kristinapathak merged commit 45093c6 into master May 26, 2020
@kristinapathak kristinapathak deleted the basic-auth-parsing branch May 26, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnabass johnabass johnabass left review comments

@joe94 joe94 joe94 approved these changes

Assignees

@kristinapathak kristinapathak

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.

Basic auth parsing utility for basculehttp
3 participants
@kristinapathak @joe94 @johnabass