Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made constructor authorization keys case sensitive #74

Merged
merged 3 commits into from
Jan 29, 2021
Merged

made constructor authorization keys case sensitive #74

merged 3 commits into from
Jan 29, 2021

Conversation

kristinapathak
Copy link
Contributor

fixes #56

@kristinapathak kristinapathak added the bug Something isn't working label Jan 29, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone Jan 29, 2021
@kristinapathak kristinapathak self-assigned this Jan 29, 2021
@codecov
Copy link

codecov bot commented Jan 29, 2021 •
edited
Loading

Codecov Report

Merging #74 (37216f3) into main (974e8e3) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   68.01%   67.91%   -0.10%     
==========================================
  Files          26       26              
  Lines         694      692       -2     
==========================================
- Hits          472      470       -2     
  Misses        203      203              
  Partials       19       19
Impacted Files Coverage Δ
basculehttp/constructor.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 974e8e3...37216f3. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

joe94
joe94 approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kristinapathak kristinapathak merged commit b408708 into main Jan 29, 2021
@kristinapathak kristinapathak deleted the case-sensitive branch January 29, 2021 19:35
@kristinapathak kristinapathak modified the milestones: v0.9.0, Unreleased Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe94 joe94 joe94 approved these changes

@ilawjr ilawjr Awaiting requested review from ilawjr

Assignees

@kristinapathak kristinapathak

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

bascule allows 'bearer' in token
2 participants
@kristinapathak @joe94