Add OnError option for the http response writer #84
Conversation
basculehttp/constructor.go
Outdated
|
|
||
| next.ServeHTTP(response, request.WithContext(ctx)) | ||
| }) | ||
| } | ||
|
|
||
| func (c *constructor) error(logger log.Logger, e ErrorResponseReason, auth string, err error) { | ||
| func (c *constructor) error(logger log.Logger, w http.ResponseWriter, e ErrorResponseReason, auth string, err error) { |
There was a problem hiding this comment.
I don't think we need the error function anymore with these changes? Aren't we just calling it once?
basculehttp/constructor.go
Outdated
|
|
||
| urlVal := *request.URL // copy the URL before modifying it | ||
| u, err := c.parseURL(&urlVal) | ||
| authentication, errReason, err := c.authenticationOutput(logger, request) |
There was a problem hiding this comment.
Feel free to ignore this comment.
authentication is kind of a long word for a variable; I would suggest just a or auth.
Codecov Report
@@ Coverage Diff @@
## main #84 +/- ##
==========================================
+ Coverage 67.78% 68.02% +0.23%
==========================================
Files 26 27 +1
Lines 683 688 +5
==========================================
+ Hits 463 468 +5
Misses 201 201
Partials 19 19
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
No description provided.