Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed use of emperror, fixed up some errors #94

Merged
merged 3 commits into from
Apr 27, 2021
Merged

Conversation

kristinapathak
Copy link
Contributor

fixes #88

@kristinapathak kristinapathak added enhancement New feature or request validator labels Apr 27, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone Apr 27, 2021
@kristinapathak kristinapathak requested a review from joe94 April 27, 2021 02:43
@kristinapathak kristinapathak self-assigned this Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #94 (7eedff1) into main (8f512df) will increase coverage by 0.17%.
The diff coverage is 69.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   66.38%   66.56%   +0.17%     
==========================================
  Files          34       34              
  Lines         937      942       +5     
==========================================
+ Hits          622      627       +5     
  Misses        296      296              
  Partials       19       19              
Impacted Files Coverage Δ
acquire/auth.go 87.50% <0.00%> (ø)
basculehttp/tokenFactory.go 45.00% <25.00%> (ø)
acquire/bearer.go 87.75% <62.50%> (+0.25%) ⬆️
basculechecks/capabilitiesmap.go 100.00% <100.00%> (ø)
basculechecks/capabilitiesvalidator.go 100.00% <100.00%> (ø)
basculechecks/endpointchecks.go 100.00% <100.00%> (ø)
basculechecks/metricvalidator.go 100.00% <100.00%> (ø)
basculehttp/enforcer.go 92.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f512df...7eedff1. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2021

@kristinapathak kristinapathak modified the milestones: v0.9.0, Unreleased Apr 27, 2021
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kristinapathak kristinapathak merged commit ebaddc7 into main Apr 27, 2021
@kristinapathak kristinapathak deleted the rm-emperror branch April 27, 2021 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request validator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove emperror pkg
2 participants