Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

converted basculechecks metrics to use touchstone #95

Merged
merged 3 commits into from
Apr 29, 2021
Merged

converted basculechecks metrics to use touchstone #95

merged 3 commits into from
Apr 29, 2021

Conversation

kristinapathak
Copy link
Contributor

@kristinapathak kristinapathak commented Apr 28, 2021 •
edited
Loading

fixes #93

@kristinapathak kristinapathak added enhancement New feature or request validator labels Apr 28, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone Apr 28, 2021
@kristinapathak kristinapathak requested a review from joe94 April 28, 2021 19:19
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #95 (0d5256d) into main (ebaddc7) will increase coverage by 0.56%.
The diff coverage is 59.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #95      +/-   ##
==========================================
+ Coverage   66.56%   67.12%   +0.56%     
==========================================
  Files          34       34              
  Lines         942      943       +1     
==========================================
+ Hits          627      633       +6     
+ Misses        296      291       -5     
  Partials       19       19
Impacted Files Coverage Δ
basculechecks/metrics.go 0.00% <0.00%> (-25.00%) ⬇️
basculechecks/metricvalidator.go 87.50% <66.66%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebaddc7...0d5256d. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 28, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

57.5% 57.5% Coverage
0.0% 0.0% Duplication

joe94
joe94 reviewed Apr 29, 2021
View reviewed changes
basculechecks/metricvalidator.go
return fx.Provide(
fx.Annotated{
Name: fmt.Sprintf("%s_bascule_capability_measures", server),
// TODO: this will be fixed when Metric Validator gets its own New()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this be part of another PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah: #87 👍

@kristinapathak kristinapathak merged commit 0515628 into main Apr 29, 2021
@kristinapathak kristinapathak deleted the touchstone branch April 29, 2021 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe94 joe94 joe94 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request validator
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Update basculechecks metrics to use touchstone
2 participants
@kristinapathak @joe94