Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return reason as a special error #97

Merged
merged 5 commits into from
May 4, 2021
Merged

return reason as a special error #97

merged 5 commits into from
May 4, 2021

Conversation

kristinapathak
Copy link
Contributor

fixes #89

@kristinapathak kristinapathak added enhancement New feature or request validator labels Apr 30, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone Apr 30, 2021
@kristinapathak kristinapathak requested a review from joe94 April 30, 2021 23:13
@codecov
Copy link

codecov bot commented Apr 30, 2021 •
edited
Loading

Codecov Report

Merging #97 (640a101) into main (0d6add6) will increase coverage by 0.58%.
The diff coverage is 100.00%.

❗ Current head 640a101 differs from pull request most recent head 90e81ab. Consider uploading reports for the commit 90e81ab to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #97      +/-   ##
==========================================
+ Coverage   67.12%   67.70%   +0.58%     
==========================================
  Files          34       35       +1     
  Lines         949      960      +11     
==========================================
+ Hits          637      650      +13     
+ Misses        292      291       -1     
+ Partials       20       19       -1
Impacted Files Coverage Δ
basculechecks/metrics.go 0.00% <ø> (ø)
basculechecks/capabilitiesmap.go 100.00% <100.00%> (ø)
basculechecks/capabilitiesvalidator.go 100.00% <100.00%> (ø)
basculechecks/errors.go 100.00% <100.00%> (ø)
basculechecks/metricvalidator.go 89.10% <100.00%> (+3.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d6add6...90e81ab. Read the comment docs.

joe94
joe94 suggested changes May 3, 2021
View reviewed changes
basculechecks/capabilitiesmap.go Outdated Show resolved Hide resolved
basculechecks/capabilitiesmap.go Outdated Show resolved Hide resolved
basculechecks/capabilitiesvalidator.go Outdated Show resolved Hide resolved
basculechecks/metricvalidator_test.go Outdated Show resolved Hide resolved
@kristinapathak kristinapathak requested a review from joe94 May 3, 2021 22:53
@sonarcloud
Copy link

sonarcloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

joe94
joe94 approved these changes May 3, 2021
View reviewed changes
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kristinapathak kristinapathak merged commit ea33d42 into main May 4, 2021
@kristinapathak kristinapathak deleted the reasoner branch May 4, 2021 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe94 joe94 joe94 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request validator
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Return metric reason as a special error interface
2 participants
@kristinapathak @joe94