Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made capability key configurable #98

Merged
merged 3 commits into from
May 4, 2021
Merged

made capability key configurable #98

merged 3 commits into from
May 4, 2021

Conversation

kristinapathak
Copy link
Contributor

fixes #92

@kristinapathak kristinapathak added enhancement New feature or request validator labels May 3, 2021
@kristinapathak kristinapathak added this to the Unreleased milestone May 3, 2021
@kristinapathak kristinapathak requested a review from joe94 May 3, 2021 20:07
@codecov
Copy link

codecov bot commented May 3, 2021 •
edited
Loading

Codecov Report

Merging #98 (e09de2c) into main (ea33d42) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head e09de2c differs from pull request most recent head 9a0108a. Consider uploading reports for the commit 9a0108a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
+ Coverage   67.70%   67.77%   +0.06%     
==========================================
  Files          35       35              
  Lines         960      962       +2     
==========================================
+ Hits          650      652       +2     
  Misses        291      291              
  Partials       19       19
Impacted Files Coverage Δ
basculechecks/capabilitiesmap.go 100.00% <100.00%> (ø)
basculechecks/capabilitiesvalidator.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea33d42...9a0108a. Read the comment docs.

joe94
joe94 reviewed May 3, 2021
View reviewed changes
basculechecks/capabilitiesvalidator.go Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
basculechecks/capabilitiesvalidator_test.go Outdated Show resolved Hide resolved
@kristinapathak kristinapathak requested a review from joe94 May 4, 2021 00:25
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

joe94
joe94 approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@kristinapathak kristinapathak merged commit 21f7b47 into main May 4, 2021
@kristinapathak kristinapathak deleted the capability-key branch May 4, 2021 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe94 joe94 joe94 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request validator
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.

Add key configuration
2 participants
@kristinapathak @joe94