Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #87
Did some other stuff too:
const
s declared inmetrics.go
.Partner
fromParsedValues
since no one is using it. I kept the struct, even though it has only one value, to make it easier to add values in a backwards-compatible way in the future.metricvalidator.go
doesn't get too big (it's still pretty big 👀).metricValidator
'sprepMetrics()
function to return a struct instead of a bunch of individual strings.ProvideMetricValidator()
so it actually kind of works.