Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset all outbound sender gauges to 0 on shutdown #204

Closed
kristinapathak opened this issue May 12, 2020 · 0 comments · Fixed by #205
Closed

Reset all outbound sender gauges to 0 on shutdown #204

kristinapathak opened this issue May 12, 2020 · 0 comments · Fixed by #205
Assignees
@kristinapathak
Labels
bug
Milestone
v0.2.8

Comments

@kristinapathak
Copy link
Contributor

caduceus/outboundSender.go

Line 333 in 00ce0db

func (obs *CaduceusOutboundSender) Shutdown(gentle bool) {

We should make sure all gauges are set to zero, so if a new outbound sender with the same url is created, it can start fresh.
@kristinapathak kristinapathak added this to the Unreleased milestone May 12, 2020
@kristinapathak kristinapathak self-assigned this May 12, 2020
@kristinapathak kristinapathak changed the title Reset all outbound sender gauges to 0 Reset all outbound sender gauges to 0 on shutdown May 12, 2020
@kristinapathak kristinapathak mentioned this issue May 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristinapathak kristinapathak

Labels
bug
Projects
None yet
Milestone
v0.2.8
Development

Successfully merging a pull request may close this issue.

updated shutdown function, also clear gauges on start and shutdown xmidt-org/caduceus
1 participant
@kristinapathak