Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated shutdown function, also clear gauges on start and shutdown #205

Merged
merged 3 commits into from
May 12, 2020
Merged

updated shutdown function, also clear gauges on start and shutdown #205

merged 3 commits into from
May 12, 2020

Conversation

kristinapathak
Copy link
Contributor

fixes #204

@kristinapathak kristinapathak added this to the Unreleased milestone May 12, 2020
@kristinapathak kristinapathak self-assigned this May 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #205 into master will decrease coverage by 0.76%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
- Coverage   69.75%   68.99%   -0.77%     
==========================================
  Files           7        7              
  Lines         744      745       +1     
==========================================
- Hits          519      514       -5     
- Misses        214      218       +4     
- Partials       11       13       +2
Impacted Files Coverage Δ
outboundSender.go 82.52% <100.00%> (-1.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00ce0db...6607cfe. Read the comment docs.

gargidb
gargidb approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@gargidb gargidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@kristinapathak kristinapathak merged commit cb60dbe into master May 12, 2020
@kristinapathak kristinapathak deleted the shutdown-fix branch May 12, 2020 23:04
@kristinapathak kristinapathak mentioned this pull request May 18, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gargidb gargidb gargidb approved these changes

@schmidtw schmidtw Awaiting requested review from schmidtw

Assignees

@kristinapathak kristinapathak

Labels
bug
Projects
None yet
Milestone
v0.2.8
Development

Successfully merging this pull request may close these issues.

Reset all outbound sender gauges to 0 on shutdown
3 participants
@kristinapathak @codecov-io @gargidb