change column name type to record_type #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kcajmagic
I made the changes that you requested on issue #8
What I did:
type
on your repo one by one, what i found that query with column name type is in 2 packages, cassandra and postgresql. I also searched in executor.go files, which have query inside. cassandra executor has notype
column, it's alreadyrecord_type
. and in postgresql executor has no column namestype
orrecord_type
.type
at the first torecordtype
, since, i don't know if this is needed or not, if it's not needed, i'll change it back to type. because this one is the top json structure, even the name of struct is Record. that doesn't specify the json name. it would look like thisto