Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove count from sql_duration_seconds metric #17

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

kcajmagic
Copy link
Member

  • fix cardinality
  • updated changelog

@codecov-io
Copy link

codecov-io commented Nov 7, 2019

Codecov Report

Merging #17 into master will increase coverage by 0.19%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   57.77%   57.97%   +0.19%     
==========================================
  Files          15       15              
  Lines        1035     1035              
==========================================
+ Hits          598      600       +2     
+ Misses        434      433       -1     
+ Partials        3        2       -1
Impacted Files Coverage Δ
cassandra/executermeasures.go 0% <0%> (ø) ⬆️
cassandra/metrics.go 100% <100%> (ø) ⬆️
batchInserter/batchInserter.go 92.77% <0%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d6e05...dcd30ee. Read the comment docs.

@kcajmagic kcajmagic merged commit f3c4856 into xmidt-org:master Nov 7, 2019
@kcajmagic kcajmagic deleted the fix/durations_metric branch November 7, 2019 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants