Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add row_id to cassandra for long polling #25

Merged
merged 6 commits into from
Jan 21, 2020

Conversation

kcajmagic
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 9, 2020

Codecov Report

Merging #25 into master will increase coverage by 0.72%.
The diff coverage is 72.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
+ Coverage    51.9%   52.62%   +0.72%     
==========================================
  Files          15       15              
  Lines         921      952      +31     
==========================================
+ Hits          478      501      +23     
- Misses        441      448       +7     
- Partials        2        3       +1
Impacted Files Coverage Δ
cassandra/executer.go 0% <0%> (ø) ⬆️
postgresql/db.go 39.06% <50%> (-0.42%) ⬇️
cassandra/db.go 59.13% <90%> (+8.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 601199a...e745819. Read the comment docs.

Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the small changes and what we talked about, it looks great!

cassandra/README.md Outdated Show resolved Hide resolved
cassandra/README.md Outdated Show resolved Hide resolved
cassandra/README.md Outdated Show resolved Hide resolved
cassandra/db.go Outdated Show resolved Hide resolved
cassandra/db.go Outdated
return latest.String(), nil
}

// GetRecords returns a list of records for a given device after a hash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// GetRecords returns a list of records for a given device after a hash
// GetRecords returns a list of records for a given device after a hash.

kcajmagic and others added 2 commits January 21, 2020 11:24
Co-Authored-By: kristinaspring <kmspring57@gmail.com>
@kcajmagic kcajmagic merged commit ad6e08e into xmidt-org:master Jan 21, 2020
@kcajmagic kcajmagic deleted the feature/timeuuid branch January 21, 2020 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants