Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Configs for OTLP Support #220

Merged
merged 6 commits into from
Dec 13, 2022
Merged

Update Configs for OTLP Support #220

merged 6 commits into from
Dec 13, 2022

Conversation

renaz6
Copy link
Member

@renaz6 renaz6 commented Dec 9, 2022

  • Updated scytale.yaml tracing configs and documentation to reflect the addition of OTLP in Candlelight
  • Updated Scytale Go version to v1.19

@guardrails
Copy link

guardrails bot commented Dec 9, 2022

⚠️ We detected 5 security issues in this pull request:

Vulnerable Libraries (5)
Severity Details
High pkg:golang/gopkg.in/yaml.v2@v2.4.0@v2.4.0 - no patch available
N/A pkg:golang/golang.org/x/net@v0.3.0@v0.3.0 upgrade to: 1.18.9,1.19.4,0.4.0
High pkg:golang/github.com/gorilla/websocket@v1.5.0@v1.5.0 - no patch available
N/A pkg:golang/github.com/aws/aws-sdk-go@v1.44.103@v1.44.103 - no patch available
High pkg:golang/github.com/hashicorp/consul/api@v1.15.3@v1.15.3 - no patch available

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@renaz6 renaz6 marked this pull request as draft December 9, 2022 17:15
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #220 (fd5826a) into main (5d4b0ee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #220   +/-   ##
=======================================
  Coverage   21.90%   21.90%           
=======================================
  Files           7        7           
  Lines         694      694           
=======================================
  Hits          152      152           
  Misses        540      540           
  Partials        2        2           
Flag Coverage Δ
unittests 21.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@renaz6 renaz6 marked this pull request as ready for review December 9, 2022 18:31
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🍻

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@renaz6 renaz6 merged commit 8dfba7d into main Dec 13, 2022
@renaz6 renaz6 deleted the addOtlpConfigs branch December 13, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants