added WRP validator middleware functionality #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #306 +/- ##
==========================================
- Coverage 21.61% 20.93% -0.68%
==========================================
Files 7 7
Lines 708 731 +23
==========================================
Hits 153 153
- Misses 553 576 +23
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
denopink
requested changes
Oct 11, 2023
primaryHandler.go
Outdated
| err := v.Validate(*msg) | ||
| if err != nil { | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| fmt.Fprintf( |
There was a problem hiding this comment.
u probably forgot to remove this print statement
primaryHandler.go
Outdated
| for _, v := range validators { | ||
| err := v.Validate(*msg) | ||
| if err != nil { | ||
| w.WriteHeader(http.StatusBadRequest) |
There was a problem hiding this comment.
we can also use http.Error()
something like this maybe
if err != nil {
bodyMsg := fmt.Sprintf(`{"code": %d, "message": "%s"}`,
http.StatusBadRequest,
fmt.Sprintf("failed to validate wrp message: %s", err))
http.Error(w, bodyMsg, http.StatusBadRequest)
return
}
denopink
approved these changes
Oct 11, 2023
denopink
reviewed
Oct 11, 2023
Comment on lines
+570
to
+571
| ctx := r.Context() | ||
| if msg, ok := wrpcontext.Get[*wrp.Message](ctx); ok { |
There was a problem hiding this comment.
Suggested change
| ctx := r.Context() | |
| if msg, ok := wrpcontext.Get[*wrp.Message](ctx); ok { | |
| if msg, ok := wrpcontext.Get[*wrp.Message](r.Context()); ok { |
denopink
reviewed
Oct 11, 2023
Comment on lines
+588
to
+589
| } | ||
| delegate.ServeHTTP(w, r) |
There was a problem hiding this comment.
Suggested change
| } | |
| delegate.ServeHTTP(w, r) | |
| } | |
| delegate.ServeHTTP(w, r) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Included:
Scytale using the standard WRP validators (SpecValidators which validates the message type, the source and destination, and that message is UTF8) from wrp-go. Validators were created in this PR