Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: fix no wrp found error #413

Merged
merged 4 commits into from
Oct 7, 2024
Merged

Bug fix: fix no wrp found error #413

merged 4 commits into from
Oct 7, 2024

Conversation

SuhasB5
Copy link
Contributor

@SuhasB5 SuhasB5 commented Sep 23, 2024

fixed an issue where "no wrp found" error was being logged for every request that went through scytale. This was creating noise in the logs as this was being logged for every request

@CLAassistant
Copy link

CLAassistant commented Sep 23, 2024

CLA assistant check
All committers have signed the CLA.

@denopink
Copy link
Contributor

denopink commented Oct 7, 2024

running checks

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 19.58%. Comparing base (96a3ecb) to head (1742232).
Report is 91 commits behind head on main.

Files with missing lines Patch % Lines
primaryHandler.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   20.67%   19.58%   -1.10%     
==========================================
  Files           7        7              
  Lines         740      623     -117     
==========================================
- Hits          153      122      -31     
+ Misses        585      499      -86     
  Partials        2        2              
Flag Coverage Δ
unittests 19.58% <0.00%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for contributing! lgtm 🍻

@denopink denopink merged commit d8f1c77 into xmidt-org:main Oct 7, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants