Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client certificate verification is broken #91

Closed
JC000 opened this issue Jun 23, 2022 · 2 comments
Closed

Client certificate verification is broken #91

JC000 opened this issue Jun 23, 2022 · 2 comments

Comments

@JC000
Copy link

JC000 commented Jun 23, 2022

Certificate verification is broken if the client supplies an ICA in the request because of the parsing logic to determine the client's CN and SAN matches conditions we're expecting.
@johnabass
Copy link
Contributor

What we want is: if any peer certificate passes custom validation, then the TLS connection is acceptable. In other words, the client may submit any number of certificates with any trust relationship, but at least (1) must pass validation.

@JC000
Copy link
Author

JC000 commented Jul 1, 2022

Fixed in PR-92

@JC000 JC000 closed this as completed Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JC000 @johnabass