Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/verify peer certificate #92

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Fix/verify peer certificate #92

merged 5 commits into from
Jun 29, 2022

Conversation

johnabass
Copy link
Contributor

This should allow ICAs to work. Including @schmidtw as well.

@johnabass johnabass requested review from schmidtw and JC000 June 27, 2022 02:11
@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #92 (b52d75b) into main (af9e00a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   82.68%   82.73%   +0.04%     
==========================================
  Files          44       44              
  Lines        1796     1801       +5     
==========================================
+ Hits         1485     1490       +5     
  Misses        291      291              
  Partials       20       20              
Flag Coverage Δ
unittests 82.73% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
xhttp/xhttpserver/tls.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d5ca35...b52d75b. Read the comment docs.

@guardrails
Copy link

guardrails bot commented Jun 27, 2022

⚠️ We detected 1 security issue in this pull request:

Insecure Use of Crypto (1)
Docs Details
💡 Title: Weak RSA key size, Severity: Medium
suite.key, err = rsa.GenerateKey(rand.Reader, 512)

More info on how to fix Insecure Use of Crypto in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@schmidtw schmidtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JC and I both reviewed this together.

@schmidtw schmidtw merged commit 1f52c0d into main Jun 29, 2022
@schmidtw schmidtw deleted the fix/verify-peer-certificate branch June 29, 2022 02:13
Copy link

@JC000 JC000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants