Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Patch Failing Dockerfile #104

Merged
merged 17 commits into from
Oct 3, 2022
Merged

Conversation

denopink
Copy link
Contributor

@denopink denopink commented Aug 31, 2022

What's included:

  • Patch failing build layers
  • Remove deprecated MAINTAINER

Fixes #106

https://github.com/comcast-cl/xmidt/issues/446
https://github.com/comcast-cl/xmidt/issues/435

@denopink denopink self-assigned this Aug 31, 2022
@denopink denopink added the bug Something isn't working label Aug 31, 2022
@denopink denopink changed the title Update Dockerfile Bug: Patch Failing Dockerfile Aug 31, 2022
@guardrails
Copy link

guardrails bot commented Sep 8, 2022

⚠️ We detected 3 security issues in this pull request:

Vulnerable Libraries (2)
Severity Details
N/A pkg:golang/golang.org/x/net@v0.0.0-20220624214902-1bab6f366d9e@v0.0.0-20220624214902-1bab6f366d9e upgrade to: 1.18.6,1.19.1,0.0.0-20220906165146-f3363e06e74c
High pkg:golang/gopkg.in/yaml.v2@v2.4.0@v2.4.0 - no patch available

More info on how to fix Vulnerable Libraries in Go.


Insecure Network Communication (1)
Docs Details
💡 Title: Insecure SSL/TLS versions allowed, Severity: Medium
return &tls.Config{} //nolint: gosec

More info on how to fix Insecure Network Communication in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@renaz6 renaz6 requested a review from johnabass September 16, 2022 16:55
@renaz6 renaz6 self-assigned this Sep 22, 2022
@renaz6 renaz6 requested a review from johnabass September 22, 2022 18:23
key/endpoint_test.go Show resolved Hide resolved
@renaz6 renaz6 requested a review from johnabass September 27, 2022 15:55
@renaz6 renaz6 requested a review from schmidtw September 27, 2022 18:45
@schmidtw schmidtw enabled auto-merge September 28, 2022 20:38
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #104 (73edb5d) into main (f47bf43) will decrease coverage by 0.89%.
The diff coverage is 80.00%.

❗ Current head 73edb5d differs from pull request most recent head a30ea95. Consider uploading reports for the commit a30ea95 to get more accurate results

@@            Coverage Diff             @@
##             main     #104      +/-   ##
==========================================
- Coverage   82.73%   81.83%   -0.90%     
==========================================
  Files          44       44              
  Lines        1801     1795       -6     
==========================================
- Hits         1490     1469      -21     
- Misses        291      306      +15     
  Partials       20       20              
Flag Coverage Δ
unittests 81.83% <80.00%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
key/handler.go 100.00% <ø> (ø)
main.go 0.00% <0.00%> (ø)
xhttp/xhttpserver/lifecycle.go 92.10% <ø> (ø)
xhttp/xhttpserver/server.go 100.00% <ø> (ø)
xhttp/xhttpserver/unmarshal.go 100.00% <ø> (ø)
xlog/context.go 100.00% <ø> (ø)
xlog/printer.go 81.81% <ø> (-18.19%) ⬇️
xlog/provide.go 100.00% <ø> (ø)
xlog/unmarshal.go 100.00% <ø> (ø)
xlog/xloghttp/connState.go 100.00% <ø> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.2% 68.2% Coverage
0.0% 0.0% Duplication

@renaz6 renaz6 dismissed johnabass’s stale review October 3, 2022 17:09

Fixed in more recent commit

@schmidtw schmidtw merged commit 9101cd4 into main Oct 3, 2022
@schmidtw schmidtw deleted the denopink/patch/golang-base-upgrade branch October 3, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Patch Failing Docker Image
4 participants