Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected bad usage of LoggerIn #136

Merged
merged 1 commit into from
Jan 3, 2023
Merged

corrected bad usage of LoggerIn #136

merged 1 commit into from
Jan 3, 2023

Conversation

johnabass
Copy link
Contributor

LoggerIn is not a type to be used as a component. It's a holder of other components.

@johnabass johnabass requested a review from renaz6 January 3, 2023 19:51
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #136 (2a74e82) into main (44f05df) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   78.40%   78.55%   +0.15%     
==========================================
  Files          35       35              
  Lines        1565     1562       -3     
==========================================
  Hits         1227     1227              
+ Misses        311      308       -3     
  Partials       27       27              
Flag Coverage Δ
unittests 78.55% <0.00%> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
main.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Jan 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@johnabass johnabass merged commit 033adaa into main Jan 3, 2023
@johnabass johnabass deleted the hotfix/unmarshal-config branch January 3, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants