Initialization first attempt. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 58.87% 63.19% +4.32%
==========================================
Files 4 4
Lines 231 269 +38
==========================================
+ Hits 136 170 +34
- Misses 95 99 +4
Continue to review full report at Codecov.
|
schmidtw
approved these changes
Sep 28, 2017
src/tr1d1um/tr1d1um.go
Outdated
| ) | ||
|
|
||
| const ( | ||
| applicationName = "tr1d1um" | ||
| DefaultKeyId = "current" | ||
| baseURI = "/api" | ||
| version = "v2"// TODO: Should these values change? |
There was a problem hiding this comment.
This should be v2 as we are not changing the API at all. Later if we make a breaking change we'll update it.
src/tr1d1um/http.go
Outdated
| // "github.com/Comcast/webpa-common/wrp" | ||
| // "encoding/json" | ||
| // "bytes" | ||
| // "fmt" |
There was a problem hiding this comment.
Just remove these unless you're going to add them back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tr1d1um runs locally with these changes.