Modified capabilities check to be more restrictive #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 86.8% 86.83% +0.02%
==========================================
Files 187 187
Lines 8201 8201
==========================================
+ Hits 7119 7121 +2
+ Misses 881 880 -1
+ Partials 201 200 -1
Continue to review full report at Codecov.
|
|
Looks OK to me other than the unit test failure. |
kcajmagic
reviewed
Nov 6, 2019
basculechecks/basculechecks.go
Outdated
|
|
||
| func CreateValidCapabilityCheck(config CapabilityConfig) func(context.Context, []interface{}) error { | ||
| func CreateValidCapabilityCheck(prefix string, acceptAllMethod string) func(context.Context, []interface{}) error { | ||
| matchPrefix := regexp.MustCompile("^" + prefix + "(.+):(.+?)$") |
There was a problem hiding this comment.
this should be error checked, or some modification/validation should happen to prefix
kcajmagic
approved these changes
Nov 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes part of #62