add session id to request response #454
Conversation
device/manager.go
Outdated
| if message.Metadata == nil { | ||
| message.Metadata = map[string]string{} | ||
| } | ||
| message.Metadata["partner-ids"] = strings.Join(event.Device.PartnerIDs(), ",") |
There was a problem hiding this comment.
Device.PartnerIDs() came from the device itself, at connection time. If the device didn't send a partner id then, it wouldn't be at this point. This doesn't help the missing partner id problem.
If we want to ensure the partner ids match, which would only be due to a device bug, then we should set message.PartnerIDs to the device's partner ids. Again, I'm not sure what the value of that is.
device/manager.go
Outdated
| message.Metadata = map[string]string{} | ||
| } | ||
| message.Metadata["partner-ids"] = strings.Join(event.Device.PartnerIDs(), ",") | ||
| message.Metadata["session-id"] = event.Device.SessionID() |
There was a problem hiding this comment.
Do we really need this? Remember that metadata is supposed to be for a device's RDK stack to populate. We use this for connect/disconnect events in talaria as hack, since those events don't come from devices.
Codecov Report
@@ Coverage Diff @@
## master #454 +/- ##
==========================================
- Coverage 86.91% 86.85% -0.06%
==========================================
Files 188 188
Lines 8313 8302 -11
==========================================
- Hits 7225 7211 -14
- Misses 886 890 +4
+ Partials 202 201 -1
Continue to review full report at Codecov.
|
No description provided.