Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default content for all WRP messages #508

Merged
merged 4 commits into from
Aug 4, 2020
Merged

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Aug 4, 2020

This is related to xmidt-org/talaria#148

Although the issue says Simple Events only, should we not also apply these to all kinds for consistency?

@joe94 joe94 requested a review from kristinapathak August 4, 2020 00:33
@joe94 joe94 self-assigned this Aug 4, 2020
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #508 into main will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   86.61%   86.59%   -0.03%     
==========================================
  Files         186      186              
  Lines        8360     8362       +2     
==========================================
  Hits         7241     7241              
- Misses        913      915       +2     
  Partials      206      206              
Impacted Files Coverage Δ
device/manager.go 59.44% <0.00%> (-0.42%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25b0ffb...e7ab41d. Read the comment docs.

@joe94 joe94 requested a review from johnabass August 4, 2020 16:52
@joe94 joe94 force-pushed the feature/defaultContentType branch from a636d4f to d6c0dce Compare August 4, 2020 20:23
@joe94 joe94 requested a review from kcajmagic August 4, 2020 20:26
@joe94 joe94 force-pushed the feature/defaultContentType branch from 26b160a to 447fbbb Compare August 4, 2020 21:58
@joe94 joe94 merged commit f53559f into main Aug 4, 2020
@joe94 joe94 deleted the feature/defaultContentType branch August 4, 2020 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants