Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add eventKey to service discovery metric #509

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

kcajmagic
Copy link
Member

The metric would be wrong if the flag crossDatacenter was enabled.

@kcajmagic kcajmagic requested a review from johnabass August 4, 2020 18:42
@kcajmagic
Copy link
Member Author

required for xmidt-org/scytale#109

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #509 into main will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   86.58%   86.62%   +0.03%     
==========================================
  Files         186      186              
  Lines        8321     8321              
==========================================
+ Hits         7205     7208       +3     
+ Misses        912      909       -3     
  Partials      204      204              
Impacted Files Coverage Δ
service/metrics.go 100.00% <100.00%> (ø)
service/monitor/listener.go 81.42% <100.00%> (ø)
device/drain/drainer.go 96.96% <0.00%> (+1.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 054e02e...debabef. Read the comment docs.

Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but let Mike know this metric has another label. It may mess up his charts.

@kcajmagic kcajmagic merged commit 41ef575 into xmidt-org:main Aug 5, 2020
@kcajmagic kcajmagic deleted the fix/sd_instance_metric branch August 5, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants