Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capcheck #523

Merged
merged 3 commits into from
Sep 30, 2020
Merged

Capcheck #523

merged 3 commits into from
Sep 30, 2020

Conversation

kristinapathak
Copy link
Contributor

Made function for determining partner id metric label value to be exported - allowing for other partner ID metrics to use it. Example of where it can be used is in Svalinn for this new metric: xmidt-org/svalinn#136

Also includes unit tests I somehow failed to commit in my last pr.

Would release the capability check changes.

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #523 into main will increase coverage by 1.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #523      +/-   ##
==========================================
+ Coverage   84.28%   85.77%   +1.49%     
==========================================
  Files         188      188              
  Lines        7176     7176              
==========================================
+ Hits         6048     6155     +107     
+ Misses        931      824     -107     
  Partials      197      197              
Impacted Files Coverage Δ
basculechecks/metricvalidator.go 100.00% <100.00%> (+100.00%) ⬆️
device/device.go 68.13% <0.00%> (-2.20%) ⬇️
device/drain/drainer.go 95.48% <0.00%> (-1.70%) ⬇️
basculechecks/capabilitycheck.go 100.00% <0.00%> (+100.00%) ⬆️
basculechecks/capabilitiesvalidator.go 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fb8f8...dfa2d8d. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@joe94 joe94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@kristinapathak kristinapathak merged commit c34d7d5 into main Sep 30, 2020
@kristinapathak kristinapathak deleted the capcheck branch September 30, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants