Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xwebhook to latest Argus codebase #557

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Conversation

joe94
Copy link
Member

@joe94 joe94 commented Jan 5, 2021

As part of the docker harmonize change, we want to have a docker compose cluster that works with latest Argus@main. This change updates the xwebhook logic that we can import into Tr1d1um and Caduceus.

@joe94 joe94 requested review from kcajmagic and j-mai January 5, 2021 02:24
@joe94
Copy link
Member Author

joe94 commented Jan 5, 2021

@j-mai I added you too as I had to update some of the datacenter code you had written.

@guardrails
Copy link

guardrails bot commented Jan 5, 2021

All previously detected findings have been fixed. Good job! 👍🎉

We will keep this comment up-to-date as you go along and notify you of any security issues that we identify.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #557 (c5be14c) into main (2226cac) will decrease coverage by 0.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #557      +/-   ##
==========================================
- Coverage   83.42%   82.78%   -0.65%     
==========================================
  Files         196      198       +2     
  Lines        7475     7597     +122     
==========================================
+ Hits         6236     6289      +53     
- Misses       1043     1109      +66     
- Partials      196      199       +3     
Impacted Files Coverage Δ
xwebhook/service.go 0.00% <0.00%> (ø)
webhook/aws/metrics.go 57.30% <0.00%> (-42.70%) ⬇️
webhook/metrics.go 57.57% <0.00%> (-42.43%) ⬇️
device/drain/drainer.go 95.48% <0.00%> (-1.70%) ⬇️
webhook/aws/sns.go 83.72% <0.00%> (ø)
webhook/factory.go 56.36% <0.00%> (ø)
bookkeeping/bookkeeper.go 83.87% <0.00%> (ø)
bookkeeping/requestResponse.go 75.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2226cac...c5be14c. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 5, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@joe94 joe94 merged commit 4574961 into main Jan 5, 2021
@joe94 joe94 deleted the feature/updateXwebhook branch January 5, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants