Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http error retry funcs #588

Merged
merged 7 commits into from
Nov 9, 2021
Merged

Http error retry funcs #588

merged 7 commits into from
Nov 9, 2021

Conversation

mtrinh11
Copy link
Contributor

No description provided.

@mtrinh11
Copy link
Contributor Author

mtrinh11 commented Oct 28, 2021 •
edited
Loading

fixes xmidt-org/caduceus#232

kristinapathak
kristinapathak approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@kristinapathak kristinapathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two small suggestions. Otherwise, we can merge once we're sure the community is good with this change. 👍

@codecov
Copy link

codecov bot commented Nov 1, 2021 •
edited
Loading

Codecov Report

Merging #588 (abc4940) into main (b88e51f) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head abc4940 differs from pull request most recent head 77c3773. Consider uploading reports for the commit 77c3773 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   84.27%   84.33%   +0.06%     
==========================================
  Files         184      184              
  Lines        8520     8540      +20     
==========================================
+ Hits         7180     7202      +22     
+ Misses       1128     1126       -2     
  Partials      212      212
Impacted Files Coverage Δ
xhttp/error.go 100.00% <ø> (ø)
xhttp/retry.go 100.00% <100.00%> (ø)
device/device.go 67.92% <0.00%> (+1.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b88e51f...77c3773. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mtrinh11 mtrinh11 merged commit 17466b7 into main Nov 9, 2021
@mtrinh11 mtrinh11 deleted the retryingonhttperror branch November 9, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinapathak kristinapathak kristinapathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mtrinh11 @kristinapathak