Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes #596

Merged
merged 4 commits into from
Apr 29, 2022
Merged

Small fixes #596

merged 4 commits into from
Apr 29, 2022

Conversation

kristinapathak
Copy link
Contributor

@kristinapathak kristinapathak commented Apr 28, 2022

bump argus, update some tests

fixes #597

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #596 (210f263) into main (9810115) will decrease coverage by 0.99%.
The diff coverage is 100.00%.

❗ Current head 210f263 differs from pull request most recent head 3775b9d. Consider uploading reports for the commit 3775b9d to get more accurate results

@@            Coverage Diff             @@
##             main     #596      +/-   ##
==========================================
- Coverage   84.32%   83.33%   -1.00%     
==========================================
  Files         184      184              
  Lines        8544     8544              
==========================================
- Hits         7205     7120      -85     
- Misses       1126     1214      +88     
+ Partials      213      210       -3     
Impacted Files Coverage Δ
webhook/aws/signature_validation.go 50.61% <ø> (-13.59%) ⬇️
service/consul/datacenterWatch.go 49.48% <100.00%> (ø)
webhook/aws/sns_handler.go 55.45% <0.00%> (-22.28%) ⬇️
webhook/aws/sns.go 72.85% <0.00%> (-12.15%) ⬇️
service/consul/instancer.go 68.10% <0.00%> (-3.45%) ⬇️
device/device.go 64.15% <0.00%> (-1.89%) ⬇️
device/drain/drainer.go 97.19% <0.00%> (-1.41%) ⬇️
device/manager.go 61.11% <0.00%> (-0.33%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74173f6...3775b9d. Read the comment docs.

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@kristinapathak kristinapathak merged commit 9e59e44 into main Apr 29, 2022
@kristinapathak kristinapathak deleted the small-fixes branch April 29, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moving away from SHA1
2 participants