Updated Metrics for Caduceus #917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurafortino
added
the
webpa-common archival/deprecation
denopink
approved these changes
Jun 14, 2023
this is likely due to a test timeout |
Codecov Report
@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 82.30% 82.08% -0.23%
==========================================
Files 138 138
Lines 8556 8573 +17
==========================================
- Hits 7042 7037 -5
- Misses 1321 1344 +23
+ Partials 193 192 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of the webpa-common deprecation.
Added a new function to create a PrometheusGauge for the caduceus. Caduceus will still need the xmetrics package - but will be able to implement the newest version of ancla.