Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Locator parsing fixes #171

Merged
merged 1 commit into from
Mar 15, 2024
Merged

fix: Locator parsing fixes #171

merged 1 commit into from
Mar 15, 2024

Conversation

schmidtw
Copy link
Member

- Fixes #169 where the output of where values are stored is wrong.
- Fixes #170 where the ignored value is truncated when it should not be.
@schmidtw schmidtw requested review from denopink and johnabass March 15, 2024 20:46
Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 52.89%. Comparing base (7f19f1b) to head (2e1866f).
Report is 2 commits behind head on main.

Files Patch % Lines
id.go 75.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   52.88%   52.89%   +0.01%     
==========================================
  Files          32       32              
  Lines        4894     4902       +8     
==========================================
+ Hits         2588     2593       +5     
- Misses       2113     2115       +2     
- Partials      193      194       +1     
Flag Coverage Δ
unittests 52.89% <75.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@johnabass johnabass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!

@schmidtw schmidtw merged commit 6606e14 into main Mar 15, 2024
17 checks passed
@schmidtw schmidtw deleted the fix-169-170 branch March 15, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Locator is truncating what is ignored based on \ characters. Event Locators handling is off
2 participants