Extend content negotiation functionality #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #47 +/- ##
=======================================
Coverage 46.61% 46.61%
=======================================
Files 15 15
Lines 3152 3152
=======================================
Hits 1469 1469
Misses 1521 1521
Partials 162 162
Continue to review full report at Codecov.
|
kcajmagic
approved these changes
Mar 11, 2020
johnabass
reviewed
Mar 12, 2020
joe94
changed the title
kristinapathak
approved these changes
Mar 27, 2020
johnabass
requested changes
Mar 28, 2020
wrphttp/requestResponse.go
Outdated
| encoder = wrp.NewEncoderBytes(&output, erw.f) | ||
| ) | ||
| func (erw *entityResponseWriter) WriteWRP(e *Entity) (int, error) { | ||
| if e == nil { |
There was a problem hiding this comment.
Generally, you don't need to do this. It's ok to allow panics on nil. That indicates a bug in the calling code, which you don't want to mask with a "normal" call return.
wrphttp/requestResponse.go
Outdated
| } | ||
|
|
||
| erw.ResponseWriter.Header().Set("Content-Type", erw.f.ContentType()) | ||
| return erw.ResponseWriter.Write(output) | ||
| } | ||
|
|
||
| func (erw *entityResponseWriter) WriteWRPFromBytes(f wrp.Format, encodedWRP []byte) (int, error) { |
There was a problem hiding this comment.
As a general naming convention, words like "from" are avoided in golang APIs. This can be just WriteWRPBytes.
johnabass
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds convenience functions for a WRP handler's content negotiation strategy.